3 Column Responsive Card w/ Flexbox

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @b-capra, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  **Hey @b-capra, regarding you question;

  Best practice it to always build you content mobile first and adapt your content for larger screen later.

  With hundreds of mobile devices and different screen sizes is more important than ever that you use responsive properties to ensure you content looks presentable in every device.

  This are just components, meaning that they are not meant to be alone. In the real world, these components would be part of a larger site. So when building these for the challenges, as long as they look presentable and do not require the user to excessively scroll, then you did good.

  Some suggestions to improve you code:

  • The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  Happy Coding! 👻🎃

  0