Submitted about 2 years ago
3 column preview-card component using Grid and Flexbox
@husamasaad
Design comparison
SolutionDesign
Solution retrospective
Hello There, I am new to using grid layout and I have question...
how can I make it responsive without using @media to change the grid-template-column ?
I tried to use repeat(auto-fill, minmax(300px, 1fr))
but it didn't work well
and any other tips are welcomed
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @husamasaad, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
- The icon doesn’t have an important role when you think about semantics and the html structure. So you can add
aria-hidden=“true”
to avoid it being found and read in the accessibility mode/screen readers. These are only decorative items. - Use
max-width: 100%
for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width). - To make your CSS code easier to work you can create a
single class
to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class. - Think about using relative units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. Anyhow, if we want a more accessible website, then we should use rem instead of px. REM does not just apply to font size, but to all sizes as well.
✌️ I hope this helps you and happy coding!
Marked as helpful1 - The icon doesn’t have an important role when you think about semantics and the html structure. So you can add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord