3 Column preview, CSS Grid

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great to see you again!! Also, you're very much welcome :>

  The layout is good in desktop and mobile state. Though an issue arises when resizing.

  • When resizing, your contents gets squished in the middle and they get very narrow which is not really Ideal. It will be really good if you make another breakpoint where/when the layout is starting to look different or destroyed. Creating this will also help the problem of appearance of scrollbar at the bottom which we always avoid.

  • On the markup, I suggest that you only use one h1 per page. Though it can be used, it will be really good if you do use only 1. It can cause problems for users who uses screen readers. You can use other heading tags. On this challenge, you can use h1 especially if it is sr only or for screen readers only.

  Overall, you did a good work and really glad that you don't used height: 100vh which I see a lot on this challenge. If need more help, just drop it here okay^^

  1