Design comparison
SolutionDesign
Solution retrospective
This time i bought pro and it was better. I had a lot of complications with this one but i did it.
Community feedback
- @vanzasetiaPosted over 2 years ago
Excellent work on this challenge, Rado! Your solution is responsive and looks great! 👏
There is some feedback from me.
- For any decorative images, each
img
tag should have emptyalt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images are decorative only. - Alternative text for images should not contain any words that related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
- The Learn More buttons would probably link elements instead of
button
elements. I think that if this a real website and the user click on the buttons, it will navigate the user to another webpage or area on the site. - Next time, always specify the
type
of thebutton
. It's going to prevent the button from behaving unexpectedly.
I hope this information is useful! Keep up the excellent work! 👍
2 - For any decorative images, each
- Account deleted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
I have some feedback on this solution:
- add cursor pointer to button so that the user knows its clickable
- add tranistion:1s; to the buttons so that when you hover on the button the background changes smoothly
i hope this is helpful and goodluck!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord