Design comparison
SolutionDesign
Solution retrospective
This was my first project working with SCSS and BEM. Any feedback is appreciated as always.
Community feedback
- @thinkclear67Posted about 3 years ago
Well done! Mobile first, using CSS custom properties, BEM. It's easy to watch and follow the HTML and related CSS. Personally I would use em's for padding and margin. In that way the margin and padding adjust automatically if you ever decide to change the font-size of an element or if the font-size changes because of different device.
Marked as helpful0@jatsanPosted about 3 years ago@thinkclear67 Thanks for taking the time to give me some feedback. I will keep what you said in mind going forward on future projects.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord