Design comparison
Solution retrospective
How did i do? All feedback will be greatly appreciated!!
Community feedback
- @correlucasPosted about 2 years ago
πΎHello Quintin Latimore, Congratulations on completing this challenge!
Your solution its almost done and Iβve some tips to help you to improve it:
Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a
single class
to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.βοΈ I hope this helps you and happy coding!
Marked as helpful0 - @VCaramesPosted about 2 years ago
Congrats @quintin156 on completing this challenge!
To clean up your code and make semantically correct, you can do the following:
<body> <article> <div> <img src="" alt=""> <h2></h2> <p></p> <a href=""></a> </div> <div> <img src="" alt=""> <h2></h2> <p></p> <a href=""></a> </div> <div> <img src="" alt=""> <h2></h2> <p></p> <a href=""></a> </div> </article> </body>
You'll notice that I wrapped everything in an <article> element and this is because this a self contained component which can be reused several times; its not the websites main content. (Link with more details on it https://developer.mozilla.org/en-US/docs/Web/HTML/Element/article)
You'll also notice that I only used three containers inside the <article> element, reason being, is that it isn't necessary to wrap each individual content in a container.
As fo headings, <h1> can ONLY be used once per page. So for this project, its better to either use <h2> heading (which can be reused several times) or a simple <p>. (Link with more details on it https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements)
Happy Coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord