Design comparison
Community feedback
- @devceejayPosted 23 days ago
Hi @pebbly12, Great job on the project! but here's my observation, I noticed that you used the h1 tag throughout the entire document. Typically, the h1 tag should be reserved for the main heading of the page, as it helps define the primary topic. For better structure, consider using h2 for main sections. This will improve the document's hierarchy, making it easier for both users and search engines to understand the content. It will also enhance accessibility and SEO.
Also, I noticed you used the <button> element styled as a button for a link. It's generally better to use the <a> (anchor) tag for navigation or linking purposes, as it’s semantically correct for this role and improves accessibility. The <button> element is typically meant for actions like submitting forms or triggering events, not for navigation. Consider replacing the <button> with an anchor tag, and keep the button styles to maintain the design you’ve applied. This will improve both the accessibility and semantics of your code.
To fix this: Write <a href="#">Learn More</a>
To keep the button styles, do this: <a href="#" class="button-link">Learn More</a> and style using the class name
Hope this helps, and great work overall!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord