Design comparison
Solution retrospective
I just completed this challenge corrections are welcome.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @Oluwatosin0, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
Use
max-width: 100%
for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a
single class
to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.✌️ I hope this helps you and happy coding!
Marked as helpful0 - @JulienK94Posted about 2 years ago
first hi seeing your solution the first thing is you have to center the main container horizontally and vertically. To do it you set display flex to the body : ex: body { height: 100vh; set the height of the body to 100% of the viewport meaning 100% of the screen which helps aligns at the center vertically display: flex; justify-content: center; here align horizontally align-items: center; here vertically } SEcondly you need to align the element to the left, you have 2 possibilities first: text-align: left; second: with Flexbox using justify-content: flex-start; here i assume it's the basics flexbox meaning row so on mobile side you'll need to change also certain things . to help i have also a video you can watch: https://www.youtube.com/watch?v=3YW65K6LcIA&t=742s
Marked as helpful0@JulienK94Posted about 2 years ago@Oluwatosin0 cool my pleasure i am in africa precisely Gabon
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord