3 Column Preview Card with grid and flexbox

Community feedback

• 

  teamie•470

  @tea-scriptsPosted over 2 years ago

  Good luck completing the project! Some things to put into consideration would be:

  • Ensure to place your entire markup in a landmark like the main.
  • When using section tags, you should stick to using h2 - h6 in place of h1
  • You should also consider adding a min-height on your cards especially for small screens. Good effort using HTML Semantics. Great work, happy coding 👍!

  0

  ---

  

  Wendy•1,990

  @wendyhamelPosted over 2 years ago

  @coder-teamie Thanks for the feedback. You were so fast that you missed my tweeks, like adding the main :smiley: I added the h1 for screenreaders. It was one of the accessibility issues from the report. (It's only visible for screenreaders) The min-height is a good one. I do use it in projects where I don't know the exact content of a card.

  0

  

  teamie•470

  @tea-scriptsPosted over 2 years ago

  @wendyhamel Oops, my bad. I just gave a review immediately I saw your submission, sorry about that 😁. Glad you were able to add some tweaks. Happy coding 👍!

  0