Design comparison
Solution retrospective
How well did I use the CSS display and position properties?
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hi there, Marcus! π
Congratulations on completing your first Frontend Mentor challenge! π Nice job on this one! π
One or two things I suggest are,
- Switching to a mobile-friendly layout sooner to prevent a horizontal scroll bar from appearing along the bottom of the page when the width of the screen decreases in the desktop layout. It's important to make your solution look good on all screen sizes so that as many people as possible can view and enjoy your work.
- Adding the light-grayish background color from the original design to the page.
- Perhaps using anchor tags (rather than
<button>
elements) for the "Learn More" elements in the card (since they seem like they will take the user somewhere when clicked). π
Also, +1 to what Vanza suggested about considering using flexbox and CSS grid in your CSSβthey certainly make laying out things a whole lot easier! π
Keep coding (and happy coding, too)! π
Marked as helpful0 - @vanzasetiaPosted over 3 years ago
πHi Marcus! My name is Vanza!
In my opinion, the way you use CSS
display
andposition
properties aren't in the right circumstances.Even though, it is working, but keep repeating yourself is not efficient, like keep adding
width
andheight
properties (because it is set toposition: absolute
) on.*-card
.For this challenge, try to use CSS Grid and CSS Flexbox, to complete this challenge again or another challenge using those technologies. It will make your CSS much cleaner and simple.
That's it! Happy Coding!
Marked as helpful0@marcus-hugoPosted over 3 years ago@vanzasetia
thanks for the reply! I'll start going over CSS Grid and Flexbox and give it another try!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord