Design comparison
SolutionDesign
Solution retrospective
Please tell me how I can improve.... :)
Community feedback
- @sab0taszPosted over 3 years ago
Hi! Good job on the challenge, however couple things need polishing.
- I don't think you actually need
.main
container. I think that.main-container
will be enough. You can then usedisplay: grid
andplace-items: center;
on it to place it in the middle. At least that's the way I do most often. - You did not put
border-radius
on the container. - I would suggest not defining heights and widths for the specific cards. Make it so the content of the card determines it's size. Use margins and padding. Only one thing I did in my challenge was setting
max-width
on the container so it does not stretch to far.
I hope it will help you somehow. Feel free to ask other questions, maybe I will be able to answer :D
Cheers!
0@sab0taszPosted over 3 years ago- Oh and more thing. You should also put
min-height: 100vh;
on thebody
tag. It should enable somewhat responsiveness when you resive the window.
0@sugi13Posted over 3 years ago@sab0tasz It was my first project..buddy.I keep doing great.. :) thank you for your feedback.
0@sab0taszPosted over 3 years agoNo worries, glad I could help, I hope this is actually the thing that should help you. Let me know when you make the changes, if they worked ;)
0 - I don't think you actually need
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord