Design comparison
Solution retrospective
I know the project is simple, but I had a little trouble making it responsive. So, I would like to know how is my CSS? Where can I improve?
Community feedback
- @vanzasetiaPosted over 2 years ago
Excellent work on this solution, Makson! Your solution looks great! π
The site looks good on both portrait and landscape mobile views! It also looks great on my desktop view! π
There are some areas that can be improved.
- I would suggest leaving the
alt
empty because all the icons are decorative images which means that if the images don't exist, there's no missing content. π - Link elements might be a better choice for all the Learn More buttons. I would expect if I click one of those buttons I would be navigated to another page or a certain part of the page. So, what do you think it's going to happen if the user clicks the button?
- By default, the
body
element has already full width so, I recommend removing thewidth: 100%
from thebody
styling. - I highly recommend using
rem
or sometimesem
unit instead ofpx
. Usingpx
will not allow the users to control the size of the page based on their needs.
About the responsiveness, I would recommend writing the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles. π
That's it! I hope this information is useful! π
Marked as helpful0@Makson19Posted over 2 years ago@vanzasetia Thank you so much, I will make sure to adjust the code.
0 - I would suggest leaving the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord