3 Column Preview Card _ ReactJs

Community feedback

• 

  Adrian H•420

  @AdrianX19Posted almost 3 years ago

  Hi @thefolake!

  Congrats on completing the challenge! :) Got a few small suggestion based on your final design:

  • on desktop the width of each card seem to be a bit too wide comparing to designs, it looks awesome on mobile so maybe try to play a little bit with it
  • you're missing the background colour and hover states, having this would be a nice complement to the final result :)
  • instead of handling border-radius with classes for each card separately you can add border-radius just for your parent and then add one extra line overflow: hidden and you will get same result!

  1

  ---

  

  folake•230

  @thefolakePosted almost 3 years ago

  @AdrianX19 Thank you so much for the feedback. I noticed the widths of the card after I submitted, but I did not bother to adjust it. But I'll do that now. I'll also fix the hover states. Wow. for the border-raduis, I dint realize I could do that. I'll try it now. Thanks a lot for the feedback

  0

  

  folake•230

  @thefolakePosted almost 3 years ago

  @AdrianX19 I made the adjustments already. Please check it out. Thank you!!

  1

  

  Adrian H•420

  @AdrianX19Posted almost 3 years ago

  @thefolake Did you set the background colour? cause if you did something didn't work as it's still white, also I would decrease padding for mobile - at least my impression is that it's too big :). The last tip would be to move 'transition' to the button instead of keeping it inside the :hover selector - thanks of that the transition will be smooth the both ways, not only when button is hovered. Sorry for being niggling - hope you don't mind! I'm really happy to see you made the adjustments! :)

  0

  

  folake•230

  @thefolakePosted almost 3 years ago

  @AdrianX19 Heyy, Funny how I dint notice the background color. But I adjusted it. Then the padding on the mobile, you meant the padding between the paragraph and the button right? I adjusted that already, I think it looks better now. Also, I added the transition to the button instead of the :hover. Makes it so much better. Thanks!

  0

  

  Adrian H•420

  @AdrianX19Posted almost 3 years ago

  @thefolake Now it's awesomesauce! :)

  1