Skip to content
Submitted 10 months ago

3 Column Preview Card

Kamran Kiani•1,210
@kaamiik
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would appreciate it if you could take a look at my code and give me feedback.

Community feedback

  • Thomas Burette•190
    @tburettePosted 10 months ago

    Nice solution!

    Your CSS could follow BEM more. You did <div class="card sedans"> but you could have done <div class="card card--sedans">. See Why the modifier CSS classes are not represented as a combined selector?

    When the button becomes active the card moves a little. Is it intentional? It could be a neat effect. If it is not : you add a border on :hover/:focus. It causes the layout to change.

    Marked as helpful
    0
    Kamran Kiani•1,210
    @kaamiikPosted 10 months ago

    Sorry for the late reply. Yes, you’re right about the class name, I changed it. Also, I added a fixed ‍‍height to the button to fix when hover. Thanks for your feedback. @tburette

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord