3 Column Preview Card Mobile First Responsive Design with CSS Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h1> so it can cause severe accessibility errors due to incorrect usage of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's a <h1> element <h1>SEDANS</h1>, you can preferably use <h2> instead of <h1>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">3-column preview card component</h1>

  ---

  • If you have any questions or need further clarification, you can always check out my submission for this challenge where i used this technique and feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  P

  Jacksen•350

  @jacksen30Posted over 1 year ago

  @0xAbdulKhalid Thanks heaps for that advice first time hearing that on here. In the past I was always given the advice of just give the components first title a <h1> tag and then once its used on a functional page swap the order of the title tags around to suit. I think your solution is much more practical though and correct in terms of accessibility. This is how I will implement a <h1> tag when building out any components in the future that wouldn't traditionally be displayed on a page by them self.

  Could you please also let me know what is the best way to find and implement emojis within these markdown comments ?

  Thank you for your help.

  0