3 Column Preview Card Component with Sass and BEM implementation

Community feedback

• 

  Siege•520

  @idesmarPosted almost 3 years ago

  Hi Jaycee, regarding your border-radius problem, you can set it on the parent container. That would be on .class__container if I read your code correctly. In the event you encounter problems with contents going beyond your container, you may want to look into overflow: hidden;. Hope I was able to help you with that problem.

  Happy coding!

  Marked as helpful

  3

  ---

  

  Jaycee Altamia•330

  @simplyJCPosted almost 3 years ago

  @idesmar Thank you for the feedback :). I will definitely try your solution.

  0
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  To avoid accessibility issues in the future, have at least one <h1> in your code

  Good job! :)

  1

  ---

  

  Jaycee Altamia•330

  @simplyJCPosted almost 3 years ago

  @anoshaahmed Oh thanks :). The reason why I didn't use <h1> because there will be multiple h1 tags. I believe it should only be one per page but I am also thinking about that I will change <h2> to <h1> instead to avoid accessibility issues .

  1

  

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  @simplyJC Yea i used <h1>s :)

  Marked as helpful

  1

  

  Jaycee Altamia•330

  @simplyJCPosted almost 3 years ago

  @anoshaahmed Yep , I already did change it to <h1> ☺️.

  1