Lucas 👾• 104,420
@correlucas
Posted
👾Hello Damian, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
- The html structure entirely with
div blocksbut these div doesn't any semantic meaning, for this reason is better you use a better html markup improving your code, for example for each vehicle card you use<article>instead of the<div>. - The icon doesn’t have an important role when you think about semantics and the html structure. So you can add
aria-hidden=“true”to avoid it being found and read in the accessibility mode/screen readers. These are only decorative items. - Use
max-width: 100%for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).
✌️ I hope this helps you and happy coding!
0
Damian• 150
@damiandev22
Posted
@correlucas I've perfored your suggestions.
I have a doubt, my html structure is like this: "<body> <main> <div class="container"> <article class="column sedans"> ... "
In order to improve the semantic structure this "<div class="container">" could be changed for a <section> tag? so it will be
<section class="container"> . What do you think?0
