3 Column Preview Card Component using Pug & SCSS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To properly center your content to your page, you will want to add the following to your Body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info:📚

  Centering in CSS

  • The “car images/icons” in this component are purely decorative; They add no value. So their Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  • The headings in your component are being used incorrectly. Since the h1 heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading since it is reusable and it will give each heading the same level of importance.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0
• 

  Nabil Wasir•680

  @NabilWasirPosted almost 2 years ago

  Great work

  Here is how you can improve your solution :

  • Use display: flex; justify-content: center; align-items: center; height: 100vh; ( Without it you can't center anything using align-items: center; )

  • You can use <main></main> instead of div/span to get rid of accessibility issues

  • Make the font-weight of the text to normal, they look slightly bolder

  • Use button:hover { background-color: transparent; border: 1px solid white( Use the color of the design ); transition: 400ms; color: white( Use the color of the design); }

  And if are having any issues understanding my feedback then watch my solution to this challenge to you clear your doubts

  Hopefully, you will find my feedback helpful.

  0

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @NabilWasir

  This is against FEM guideline, which can cause your account to be deleted.

  "If you do find my feedback helpful don't forget to mark this comment helpful!"

  "Ask people to mark your comment as helpful — A big part of Frontend Mentor is helping each other out and providing feedback. If you give some feedback, please avoid saying things like, "if you found this feedback useful, please mark this comment as helpful". It places unnecessary pressure on the solution author to mark your comment as helpful, which is best avoided. Feel free to say something like, "I hope you find this helpful", but please avoid asking for your comment to be marked as helpful outright."

  0