3 Column preview card component using css

Community feedback

• 

  Vincent Daniel•410

  @davinceeyPosted about 2 years ago

  Hello Gustavo Costa!. Congratulations on your first project! It's a wonderful one on the whole! Just some little tips for you:

  1. You might want to replace the <section> tag used to wrap everything, with a <main> tag and then, use the <section> tag to replace the numerous divs used to partition your layout. This would help to improve Accessibility

  2. From your code, <span><h1>SUVS</h1></span><br />, you placed h1 inside a span which is not a good html practice. You could do well to remove the span as it causes inadequate HTML validation.

  On the bright side, this is a beautiful project! Well-done.

  Hope this helps you. Happy Coding!💖

  Marked as helpful

  1
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Gustavo Costa, Congratulations on completing this challenge!

  Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:

  To make your CSS code easier to work you can create a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class. Use max-width: 100% for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Gustavo Costa•50

  @costaguhPosted about 2 years ago

  @correlucas Obrigado Lucas, vou corrigir os erros!

  1

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @costaguh Boa, tmj

  Marked as helpful

  1