Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3 column preview card component using css grid

@Gabriel-Leao

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi dev community, here is my solution for this challenge. Aligning the three columns next to each other was tricky, but the button was easy and fun. I am from Brazil and did this challenge listening to the sounds of the Beach Boys pets.

Community feedback

PhoenixDev22 16,950

@PhoenixDev22

Posted

Hello @Gabriel-Leao,

I have some suggestions regarding your solution:

  • There should be two landmark components as children of the body element - a main (which will be the component) and a footer (which will be the attribution).

  • For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images are decorative only.`

  • you can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech). and make the other heading tags to h2.

.sr-only {
	border: 0 !important;
	clip: rect(1px, 1px, 1px, 1px) !important;
	-webkit-clip-path: inset(50%) !important;
		clip-path: inset(50%) !important; 
	height: 1px !important;
	margin: -1px !important;
	overflow: hidden !important;
	padding: 0 !important;
	position: absolute !important;
	width: 1px !important;
	white-space: nowrap !important;            
}

  • don't capitalise in html, let css text transform take care of that. Remember screen readers won't be able to Read capitalised text as they will often read them letter by letter thinking they are acronyms.

  • border-radius and overflow hidden to the container that wraps the three cards.so you don't have to set it to individual corners.

  • You can use flexbox properties and min-height: 100vh; to the body to center the component on the middle of the page.

Overall , your solution is good . Hopefully this feedback helps

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord