3 column preview card component main

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Brobit 👋🏻

  I have some suggestions to help you fix the accessibility, HTML and some other issues.

  • First, in your HTML, <div class="giga-content">...</div> should be <main class="giga-content">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
  • Next, for the car icons, they should have aria-hidden="true”, because the icons are for decoration. You can read more about aria-hidden here.
  • Avoid using !important as much as you can, you should give classes to things that you want to change and work on them in your CSS file. Also, avoid inline styling, like this style='align-items: flex-end;'. Check out this link to learn more about CSS specificity.

  I hope this was helpful 👨🏻‍💻 overall, you did a great job, responsiveness nicely done. Cheers 👾

  Marked as helpful

  1
• 

  Paminos•230

  @epalpamPosted about 3 years ago

  @Brobit

  good job done!! congrats

  Some comments from my side:

  • try to use semantic html, eg. instead of div use tags like section, main, header etc ect

  • your css code is not so easy to follow, try to make it more readable !

  Marked as helpful

  1

  ---

  

  Brobit•60

  @BrobitPosted about 3 years ago

  @epameinondas-paminos ok ty :)

  0

  

  Brobit•60

  @BrobitPosted about 3 years ago

  @Brobit ty , i will applied you're advice for futur project

  0