Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To properly center your content to your page, you will want to add the following to your Body Element (this method uses CSS Grid):
body { min-height: 100vh; display: grid; place-content: center; }
-
Along with the Blank Alt Tag, you also want to include the aria-hidden=“true” to your car images/icons to fully remove them from assistive technology.
-
The headings in your component are being used incorrectly. Since the
<h1>
Heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an<h2>
Heading, since it is reusable and it will give each heading the same level of importance. -
Your "buttons" were created with the incorrect element. When the user clicks on the button they should bedirected to a different part of you site. The
<a>
Anchor Tag will achieve this. -
The button styling is not correct; it should be a solid white and when hovered the white border should appear.
-
Change the
width
of your components container tomax-width
to make it responsive.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord