Design comparison
Solution retrospective
I would like some advices regarding the mobile version website, I think I messed that up a little bit.
Community feedback
- @VCaramesPosted about 2 years ago
Hey there!👋 Here are some suggestions to help improve your code:
-
Your car images/icons need to have a Blank Alt Tag and a aria-hidden=“true” to your to fully remove it from assistive technology.
-
The headings in your component are being used incorrectly. Since the <h1> Heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an <h2> Heading, since it is reusable and it will give each heading the same level of importance.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
-
Reduce 📉 the “height” of the component to better match the FEM example.
-
Change the
width
of your components container tomax-width
to make it responsive. -
Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord