@VCarames
Posted
Hey @rahmadsubakti, some suggestions to improve you code:
- Implement a Mobile First approach 📱
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
- All you need to need in the Body Element to center an add padding to your card is the following:
body {
min-height: 100vh;
display: grid;
place-content: center;
padding: 20px;
background-color: hsl(0deg, 0%, 95%);
font-family: "Lexend Deca", sans-serif;
}
- To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
<body>
<main>
<article>
<article class="sedan-card"></article>
<article class="sedan-card"></article>
<article class="luxury-card"></article>
</article>
</main>
<footer class="attribution"></footer>
</body>
The Main Element identifies the main content of the document.
While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.
Lastly, each card will be wrapped in their own Article Element because they too, are complete, or self-contained, section of content that is, in principle, independently reusable.
More info:
https://web.dev/learn/html/headings-and-sections/
-
The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
-
The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
Happy Coding! 👻🎃
Marked as helpful
