3 column preview card component CSS/HTML

Community feedback

• 

  Harsh Kumar•1,390

  @thisisharsh7Posted about 2 years ago

  Hey Marko Djurdjevic, Great Job! your solution looks perfect but there are some improvements which could be made

  1. Avoid the manual margin to make content align on the center like here you did .main-container{ margin: 0 auto; } can be removed because the content already is on the center when you give body flex and justify-content center property . Also this top and bottom margin 0 make the content stick to both the ends and hence design look unhealthy.

  2. Avoid using media queries at every screen size.

  hope this helps...

  0

  ---

  

  Marko Djurdjevic•210

  @FrozennnPosted about 2 years ago

  @thisisharsh7 Hey, thanks for the comment.

  1. Yes the reason why I chose to do margin: 0 auto and not justify-content: the center was because on some lower resolutions my content was above the page and some part was cut and that was the only fix I could find. But you are right, the design does look worse I should have come up with a better solution.

  2. Why is it bad to use media queries for every screen size? And if not with media queries how would I fix the design on some lower resolutions then?

  0

  

  Harsh Kumar•1,390

  @thisisharsh7Posted about 2 years ago

  Hey Marko, there is nothing wrong in using media queries but here you are using media query at 920px and I think this part of your solution could have been better alternative.

  0