3 Column Preview Card Component by Flex box and Mobile-First Approach

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h1> so it can cause severe accessibility errors due to incorrect usage of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's three <h1> elements, like this <h1>SEDANS</h1>, you can preferably use <h2> instead of <h1>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">3-column preview card component</h1>

  ---

  • If you have any questions or need further clarification, you can always check out my submission for this challenge where i used this technique and feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Reza Sajjadian•290

  @reza-sjdnPosted over 1 year ago

  Hello Dear @0xAbdulKhalid, I was entering your feedbacks into my solution that I encountered a strange bug!

  Set @media (min-width: 992px) and Make the screen like 980px wide and then the second card becomes more wider than two others! I NEVER had a problem like this and I have know idea to handle this.

  I'd be appreciated if you helped me with this.

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Can you share me the resolution when you faced this issue @reza-sjdn ?

  For Example: 1440x800

  I mean the measurement you see during opening Responsive Design mode on Browsers

  0

  

  Reza Sajjadian•290

  @reza-sjdnPosted over 1 year ago

  980x542

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  No Bro @reza-sjdn, The preview looks fine!

  Take a look at this screenshot

  I think the browser's vendor fixed styles are applying for your components

  What browser are you currently using ?

  0

  

  Reza Sajjadian•290

  @reza-sjdnPosted over 1 year ago

  It's dealt with. thanks

  0