Design comparison
Solution retrospective
I used the BEM convention for naming my HTML elements, and I had a great experience! I'd strongly recommend looking into it if you spend too much time dealing with styling collisions or coming up with perfect names for your elements.
Community feedback
- @VCaramesPosted about 2 years ago
Hey @jeremylloyd, some suggestions to improve you code:
-
The car images/icons serve no other purpose than to be decorative; They add no value. There Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
-
The headings are being use incorrectly. The <h1> Heading can only be used ONCE per page. For this challenge, we are assuming that is it part of larger website. So your safe option is to use the <h2> Heading, because it will give each card the same level of importance and it's reusable.
-
To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
More Info:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
Happy Coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord