3-column-preview-card-component

Community feedback

• 

  

  Chamu•13,710

  @ChamuMutezvaPosted 3 months ago

  Hi Sulley-Sadick

  • it is good that you are using landmark elements like the main. The attribution should also be a landmark to keep the best practices. You can use the footer element for the div with class attribution
  • when it comes to the h1 element, for best practice you should have one h1 element. Since this is just a component you can skip the h1 heading element and make all the heading elements h2
  • you have used an input element of type submit, the question I would ask is , what are you submitting? Using semantic elements always is recommended, these should have been anchor elements - links that take you to a section or page with more details
  • check for some modern reset stylesheet on the internet. One common one is by Andy Bell
  • font sizes should be in rem, see the following article for a detailled explanation font sizes
  • avoid chaining styles like in this example .preview-card .desc , apply the styles to the direct element as in .desc
  • you don't have to keep on submitting the same solution multiple times. Even after making changes , you don't need to do anything your updates will be effected immediately. You can generate a new screenshot if you need to compare the presentation

  Marked as helpful

  0
• 

  Sadick Sulley•280

  @Sulley-SadickPosted 3 months ago

  Thank you very much for pinpointing some mistakes I made along the line, I really appreciate your effort putting in to help me to become a better programmer in the future. I would be very glad if you would check on me if I make mistake whiles trying to be a better developer.

  0