
Design comparison
Solution retrospective
Being able to solve the challenge without watching any tutorial while coding along and did it through some normal research
What challenges did you encounter, and how did you overcome them?Shifting from mobile design to desktop design using the media queries properties, I did some research on media queries and then applied the knowledge I learnt from the research.
What specific areas of your project would you like help with?I would be happy if I can get any assistance of anyone willing to guide me through the application of media queries.
Community feedback
- @ChamuMutezvaPosted 3 months ago
Hi Sulley-Sadick
- it is good that you are using landmark elements like the main. The
attribution
should also be a landmark to keep the best practices. You can use thefooter
element for the div with classattribution
- when it comes to the
h1
element, for best practice you should have oneh1
element. Since this is just a component you can skip theh1
heading element and make all the heading elementsh2
- you have used an input element of type submit, the question I would ask is , what are you submitting? Using semantic elements always is recommended, these should have been anchor elements - links that take you to a section or page with more details
- check for some modern reset stylesheet on the internet. One common one is by Andy Bell
- font sizes should be in rem, see the following article for a detailled explanation font sizes
- avoid chaining styles like in this example
.preview-card .desc
, apply the styles to the direct element as in.desc
- you don't have to keep on submitting the same solution multiple times. Even after making changes , you don't need to do anything your updates will be effected immediately. You can generate a new screenshot if you need to compare the presentation
Marked as helpful0 - it is good that you are using landmark elements like the main. The
- @Sulley-SadickPosted 3 months ago
Thank you very much for pinpointing some mistakes I made along the line, I really appreciate your effort putting in to help me to become a better programmer in the future. I would be very glad if you would check on me if I make mistake whiles trying to be a better developer.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord