Design comparison
SolutionDesign
Solution retrospective
fun little practice for the day, any feedback would be great, thank you.
Community feedback
- @Ahmed-ElbaldPosted over 2 years ago
Hey Rick, I've some notes on your solution. I hope you find them helpful.
- It's always a good practice to have a
<main>
landmark in your page (only one). You are doing that actually but it can't be a child of another element as it's a landmark so it could be a replacement to yourdiv.container
. - It's also a good practice to have at least an
h1
in the page so you can replace yourh2
s withh1
s - and finally a
p
tag shouldn't be inside abutton
tag. You can replace it with aspan
.
Thank you
1 - It's always a good practice to have a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord