3 column preview card component

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Kerdael 👋🏻

  I have some tips to help you fix the accessibility issues and some other things.

  • In your markup, <div class="container">...</div> should be <main class="container">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
  • Next, For the car icons, add aria-hidden="true”, because they are for decoration. You can read more about aria-hidden here. To illustrate:

  <img src="/images/icon-sedans.svg" alt="" aria-hidden="true”>
  

  • Also, I suggest implementing :hover state, which you can find in design folder active-state image, after you implement it you can also add transition: all 0.2s; to the button and the links, this will make :hover smoother.

  I hope this was helpful 👨🏻‍💻 Overall, you did a great job, especially with responsiveness, keep it up. Cheers 👾

  Marked as helpful

  1

  ---

  

  Cedric Chauvet•95

  @KerdaelPosted about 3 years ago

  Hi @kens-visuals !

  Thank you very much for your feedback! You helped a lot. My site looks better now. And I learned a few tings along the way which is awesome.

  Take care, Kerdael

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hi @Kerdael 👋🏻

  You're welcome, I'm glad to be helpful 😇

  You too!

  0