3 Column Preview Card Component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="container">with the main tag, <div class="attribution"> with the footer tag and the html must have <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  You forgot to give the body a background-color,

  To center .container on the page using flexbox or grid instead of margin,

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: Add min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  For a responsive content, there is no need to give .container, .sedan , .suv and .luxury a height value rather give .sedan , .suv and .luxury the same padding value for all the sides, this will prevent the content from overflowing.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  You forgot to add a media query for the mobile design. For more on media queries, click here.

  Always begin with the mobile design first, this will make the process a little bit easier.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0