3 Column Preview Card Component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there!👋 Here are some suggestions to help improve your code:

  • The purpose of the Main Element is to identify the main content of your page. It is not the container of you component. After the main element, you want add a container to wrap you separate components in.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  1

  ---

  

  gustavo•40

  @machadogustavoPosted about 2 years ago

  @vcarames Thanks for the suggestions, I will join this approach mobile first ! 🙏

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,160

  @MelvinAguilarPosted about 2 years ago

  Hi @machadogustavo 👋, good job on completing this challenge! 🎉

  I have some suggestions you might consider to improve your code:

  • The Learn More elements should be anchor tags and not buttons because they redirect to another part of the page.

  • The <h1> element is the main heading on a web page. There should only be one <h1> tag per page. This case requires that SUVS, SEDANS, and LUXURY be <h2> elements.

  • Car icons are for decoration purposes only, so they can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty:

  <img src="./images/icon-sedans.svg" alt aria-hidden="true">
  <img src="./images/icon-suvs.svg" alt aria-hidden="true" >
  <img src="./images/icon-luxury.svg" alt aria-hidden="true" >
  

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  1

  ---

  

  gustavo•40

  @machadogustavoPosted about 2 years ago

  @MelvinAguilar Thanks for the tips, I will apply them to improve my code 👍🤝

  1