Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3 Column Preview Card Component

gustavoβ€’ 40

@machadogustavo

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Goodnight! Open to suggestions and tips to improve my code! πŸ“

Community feedback

@VCarames

Posted

Hey there!πŸ‘‹ Here are some suggestions to help improve your code:

  • The purpose of the Main Element is to identify the main content of your page. It is not the container of you component. After the main element, you want add a container to wrap you separate components in.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  • Implement a Mobile First approach πŸ“± > πŸ–₯

With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

If you have any questions or need further clarification, let me know.

Happy Coding! πŸ‘»πŸŽƒ

Marked as helpful

1

gustavoβ€’ 40

@machadogustavo

Posted

@vcarames Thanks for the suggestions, I will join this approach mobile first ! πŸ™

0

@MelvinAguilar

Posted

Hi @machadogustavo πŸ‘‹, good job on completing this challenge! πŸŽ‰

I have some suggestions you might consider to improve your code:

  • The Learn More elements should be anchor tags and not buttons because they redirect to another part of the page.

  • The <h1> element is the main heading on a web page. There should only be one <h1> tag per page. This case requires that SUVS, SEDANS, and LUXURY be <h2> elements.

  • Car icons are for decoration purposes only, so they can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty:

<img src="./images/icon-sedans.svg" alt aria-hidden="true">
<img src="./images/icon-suvs.svg" alt aria-hidden="true" >
<img src="./images/icon-luxury.svg" alt aria-hidden="true" >

I hope those tips will help you! πŸ‘

Good job, and happy coding! 😁

Marked as helpful

1

gustavoβ€’ 40

@machadogustavo

Posted

@MelvinAguilar Thanks for the tips, I will apply them to improve my code πŸ‘πŸ€

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord