3 column preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey , adding to what was said above/below:

  • The headings are being use incorrectly. The <h1> Heading can only be used ONCE per page. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.

  • Add a padding of about 20px to your Body Element so your card does not touch the sides of the screen.

  • Start your media query sooner.

  Happy Coding!

  Marked as helpful

  0

  ---

  

  tbahd•160

  @tbahdPosted about 2 years ago

  @vcarames thanks for the feedback but please what do you mean by starting my media query sooner?

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @tbahd

  At around 582px, your paragraph text begins to overflow to your buttons.

  0

  

  tbahd•160

  @tbahdPosted about 2 years ago

  @vcarames can you help with any suitable solution please?

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @tbahd, congrats on completing this challenge!

  I've just opened your live site and I can say that you did a great job putting everything together! There's some tips to improve your solution:

  Think about using relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.Anyhow, if we want a more accessible website, then we should use rem instead of px. REM does not just apply to font size, but to all sizes as well.

  Improve your html markup using meaningful tags to wrap the content, you can replace the div you’ve used for each card with <article>. Remember to wrap big blocks of content with semantic tags and never divs, use divs for small blocks.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  tbahd•160

  @tbahdPosted about 2 years ago

  Hey @correlucas, hope this meets you well!

  I really appreciate you noticing and going through my solutions and also taking time out to send me corrections. I've taken note of these corrections and will apply them now and in future projects.

  Thank you!

  0