3 Column Preview Card Component

Community feedback

• 

  Freivys Paredes•110

  @FreivysDevPosted about 2 years ago

  Hi @MelvinAguilar, thanks for your suggestions. I am going to document more about the accessibility part to give the best user experience. Likewise, I'm going to apply the changes to the code. I keep learning new things. Thanks.

  1
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @freivys 👋, good job on completing this challenge! 🎉

  I like this solution for the challenge. I have some suggestions you might consider to improve your code:

  • The Learn More elements should be anchor tags and not buttons because they redirect to another part of the page.

  • Car icons are for decoration purposes only, so they can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty:

  <img class="card__icon" src="./images/icon-sedans.svg" alt aria-hidden="true">
  <img class="card__icon" src="./images/icon-suvs.svg" alt aria-hidden="true" >
  <img class="card__icon" src="./images/icon-luxury.svg" alt aria-hidden="true" >
  

  Good job, and happy coding! 😁

  0