Design comparison
Solution retrospective
Hi everyone! This is my solution for the "3 column preview card component" challenge.
This was one of my first projects with ReactJs, and I'm investigating in order to be able to develop more projects in this way.
Thanks for your time, and I´m open to receive reviews!
Community feedback
- @VCaramesPosted about 2 years ago
Hey there!👋 Here are some suggestions to help improve your code:
-
The car images/icons in this component are purely decorative; They add no value. So their Alt Tag should left blank and have an aria-hidden=“true” to hides them from assistive technology.
-
The headings in your component are being used incorrectly. Since the <h1> Heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an <h2> Heading, since it is reusable and it will give each heading the same level of importance.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful0@juanardanazPosted about 2 years agoHey @vcarames!
Thank you very much for your review!
You are right, good observation. I will fix it up and push the changes.
Happy Coding too!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord