3 column preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @HubertSzymanski5, some suggestions to improve you code:

  • The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The headings are being use incorrectly. The <h1> Heading can only be used ONCE per page. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  Happy Coding! 👻🎃

  Marked as helpful

  1
• 

  TITOR•340

  @hectorestebanmPosted about 2 years ago

  Buenas @ HubertSzymanski5 Estuve viendo tu código y podrías probar lo siguiente para que se vea mejor. Dentro de tu body agrega los siguientes códigos: body { flex-direction: column; align-items; min-height: 100vh; }

  Con esto todos tus elementos se ubicarán uno encima de otro en forma vertical y estarán centrados en el medio de la pantalla, tanto para la parte móvil cómo para desktop.

  Otro consejo, deberías quitar el position: fixed del footer, ya que sino tapará parte de tu diseño. Espero te sirvan estos consejos.

  0