Design comparison
SolutionDesign
Solution retrospective
I don't have any comments, can't wait to get to the challenges involving JavaScript too. If you have anything to comment on, please do!
Community feedback
- @fatlindshehuPosted over 2 years ago
Hi @waikoo,
Your component looks great, it's responsive, and it fits very good on small screen devices, I would suggest some general changes and a tiny detail:
- The
border-radius
makes the button bigger, I think you should use a different approach to make the outline show as in the design. - To the button set a border ex
border: 1px solid transparent;
you set it as transparent because you don't want it to show on the main state. button:hover { background: transparent; border-color: var(--white); color: var(--white);}
on hover you set thebackground
to transparent and thebutton
to white and the outline shows from the inside & the size of the button doesn't change.
For general purposes, I would suggest using
rem
instead ofpx
, px tend to be problematic on bigger projects when trying to make the site responsive.Keep it up & happy coding...
Marked as helpful1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord