3 Column Preview Card

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • The link to the Github repository is not working.

  • You should not recreate the background, the only background color that this solution should have is grey, you have used the image desktop-preview.jpg to create your solution, but that image is for decoration purposes and it's a nice way to present the challenge, for example, you can use it to place it in your README of your github.

    To create your solution you must use the images desktop-design.jpg and mobile-design.jpg.

  HTML 📄:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • You should use only one <h1> tag per page. The <h1> tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires that Sedans, SUVs and Luxury are headings, but you can use the <h2> tag instead of the <h1> tag. You can read more about this here 📘.

  • You should use the <a> tag instead of the <button> tag because the Learn More button is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here 📘.

  I hope you find it useful! 😄

  Happy coding!

  0