Design comparison
SolutionDesign
Solution retrospective
Feel free to put some comments on this challenge.
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @iulian5 👋🏻
I have some feedback on some minor issues and also some help for the accessibility issues.
- I think you should add
cursor: pointer;
to:hover
state of the buttons - Also, you should change the
color
of the footer to something darker, so it becomes visible. - In your markup <div class="container">...</div> should be <main class="container">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
I hope this was helpful 👨🏻💻 other than those, everything else looks great. Cheers 👾
Marked as helpful0 - I think you should add
- @iulian5Posted about 3 years ago
Thanks, for your help ! I'll do it and make another report
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord