3 Column CSS Grid

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey @duchessa01, some suggestions to improve you code:

  • The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  Happy Coding! 👻🎃

  Marked as helpful

  0
• Account deleted

  Hello @duchessa01,

  • Your solution looks great and I suggest you add on hover affect on the Learn more buttons.

  button:hover{
   border: 1px solid white;
    background: none;
    color: var(--light-gray-color);
  }
  
  

  • Add another class to button so when hover the color matches each card

  btn-orange{
  color: hsl(31, 77%, 52%);
  }
  
  

  I hope this helps you and good luck

  Marked as helpful

  0

  ---

  

  Duchessa•70

  @duchessa01Posted about 2 years ago

  @bccpadge Hi! Thank you so much Rebecca!

  Now I know I coded everything by looking at the "active state" screenshot without realizing it ahaha

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @duchessa01, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  0