Design comparison
SolutionDesign
Solution retrospective
Pretty simple and straight forward challenge. If anyone wants to check out my code and tell me if I could clean anything up or adopt a better practice somewhere, that would be much appreciated!
Community feedback
- @Zy8712Posted 10 months ago
Your site looks great! The only changes I would make are:
- using a
<button>instead of<a>for the buttons, this is for accessibility reasons - if you want to use
<h1>I suggest you instead of placing<h1>for "Sedans", you should change it to<h2>so all the columns have the same header. Then add an<h1>header somewhere in your code that describes the page, you can then hide the header withdisplay: none.
Aside from that your site looks great. Nice work 👍
Marked as helpful0@scotttaborPosted 10 months ago@Zy8712 thanks for the tips! I was wondering how the headers should go in a situation like this, that makes a lot of sense.
0 - using a
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord