Design comparison
Solution retrospective
Thoughts?
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@AnthvirusPosted over 1 year agoMan, thanks a lot. I pray for your comments every time I submit a task@0xAbdulKhalid
0 - @HassiaiPosted over 1 year ago
Give h1 a font family of 'Lexend Deca', sans-serif; and p a font-family of 'Big Shoulders Display', sans-serif; .
To center thee main on the page using flexbox, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
There is no need to give the body a margin , height and padding value. There is no need to give the main a margin value.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0@AnthvirusPosted over 1 year agoI did that in the code and it's still not working @Hassiai
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord