3 Column Card

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  AnthMan•190

  @AnthvirusPosted over 1 year ago

  Man, thanks a lot. I pray for your comments every time I submit a task@0xAbdulKhalid

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Give h1 a font family of 'Lexend Deca', sans-serif; and p a font-family of 'Big Shoulders Display', sans-serif; .

  To center thee main on the page using flexbox, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  There is no need to give the body a margin , height and padding value. There is no need to give the main a margin value.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0

  ---

  

  AnthMan•190

  @AnthvirusPosted over 1 year ago

  I did that in the code and it's still not working @Hassiai

  0