Account Deleted
Hi Devesh,
The sites looks very good. An issue I saw was when the browser shrinks, the cards stay the same. I suggest you change your .card-container to be one column. You can do that by changing your grid-template-column to 1fr. From there, you can change your max-width so it doesn't cover the entire screen.
Also, I believe you only use rem for font-size, not max-width. You would use em for that. For an explanation why, I suggest you google it.
The only other thing I have to say is not considered best practice to use display: flex for your body. If you want to center your .card-container, then I would create a main tag above .card-container & change .card-container to a div tag. Then, put your display: flex & all its components within that main tag.
I hope all that helps you.
Marked as helpful
@devesht21
Posted
@mrsimms430 Thank you for your helpful feedback. I will take care of that in the next project. Thanks once again!
