@correlucas
Posted
👾Hello @WorldWideWeb-er, Congratulations on completing this challenge!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
1.You've done the design for the wrong image, when you download the starter files the folder comes with 3 files (preview card, desktop and mobile) you've created the solution based on the preview
and you should consider only the mobile + desktop images
.
Remove the background-color
from the container and add it to the body
to make sure this color background will display it full screen.
2.Use units as rem
or em
instead of px
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but all sizes as well.
3.Don’t use id
to give the style of your elements, it's not a good idea because id
is a too specific selector used for forms
and Javascript code. Instead, use class
for styling and let the id
for much specific stuff. It's also not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.
✌️ I hope this helps you and happy coding!