Design comparison
SolutionDesign
Solution retrospective
Any feedback would be appreciated.
Community feedback
- @darryncodesPosted over 3 years ago
Hi Mohamed,
Good work on your solution, really responsive!
A couple of observations from me:
- semantically your 'Learn More'
<div>
and<p>
should be a<button>
- you could add
cursor: pointer;
to.card_btn
so it feels more like a button and gives the user feedback - you could set a transition property so when the user hovers over the button the hover affect is smoother for example: transition: .3s; or transition: ease-in .3s;
Happy coding!
Marked as helpful1@Mahii143Posted over 3 years ago@darryncodes Thank you very much bro, I'm going to make changes as you mentioned.
0 - semantically your 'Learn More'
- @SaifN97Posted over 3 years ago
Hey Mohamed Mahir great job on this one!
The card content is flowing out while going small. I'll suggest avoid setting a fixed
height
to your cards and usepadding
whenever you need more background space.Have fun coding :)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord