3 Column Card Layout

Community feedback

• 

  Reydel Ocon•385

  @reydelshitPosted about 3 years ago

  i used overflow: hidden; to the father div to make the border radius visible

  Marked as helpful

  1

  ---

  

  Celumusa B Duma•70

  @celumusaBDumaPosted about 3 years ago

  @reydelshit That worked, thanks a lot :-)

  0
• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @celumusaBDuma 👋🏻

  I have some suggestions to help you fix a couple of problems related to accessibility, HTML and some other issues.

  • For accessibility issues, there are a couple of things that you should fix. First, <div class="features">...</div> should be <main class="features">...</main>, Second, you cannot have more than one <header> or <footer> tags, I'd suggest just replacing them with regular <div>s. After you fix them, those accessibility issues should be gone. Please don't forget to generate a new report after fixing them.
  • I noticed that you're missing the fonts, they're really easy to add, and you can find correct ones in your style-guide.md. Open them in Google Fonts and then add the links to the head of your document, as you'd do with CSS links.
  • Lastly, this is more of a personal opinion, I'd slightly change padding and border-radius on buttons to something like this,

  padding: 1.5rem 2rem;
  border-radius: 40px;
  

  I hope this was helpful 👨🏻‍💻, you did a really good job. Cheers 👾

  2