3 column card component using CSS GRID and FLEXBOX

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen-readers by leaving its alt attribute empty. You can read more about this here 📘.

  CSS 🎨:

  • The fonts are too small; it's rarely a good idea to have fonts below 16px or 1rem. It makes reading the text difficult.

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Donald Zarura•210

  @doniecodesPosted 11 months ago

  Hello @MelvinAguilar .THANK YOU SO MUCH for that { i really appreciate it: 100%; }

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @DonieCode!

  Great solution for a project coded on a mobile device 😁

  0

  ---

  

  Donald Zarura•210

  @doniecodesPosted 11 months ago

  @danielmrz-dev Thank you man. 😁

  0