Submitted almost 3 years ago
3 Column Card Component. Styled with CSS flex and responsive
@thomasjfcaldwell
Design comparison
SolutionDesign
Solution retrospective
Would LOVE to hear some feedback and hopefully learn how to improve! Thanks All
Community feedback
- @grace-snowPosted almost 3 years ago
Hello
Some of the text on this is unreadably small and image icons tiny as well. The style guide font size is for mobile as well, it shouldn’t be shrunk down for mobile users
Other tips
- never have font size in px ever. Use rem
- never style on IDs, use single class selectors and keep specificity as low as possible
- the buttons in this should be anchor tags
- as well as hover styles, always add obvious focus-visible styles to interactive elements
- the massive indentation on your code is making it really hard for others to read. Most people only use 2 or max 4 spaces for tab size
Marked as helpful3
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord