3 column card

Community feedback

• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Congrats on completing the challenge, @PitagoraStrike!

  I had a look at your final solution and Github repo. Here are a few suggestions that might help:

  • On larger screen sizes, there's a bit too much space at the top

  • Responsiveness needs a bit of polishing - you have horizontal scrolling on smaller screen sizes

  • Don't use fixed width and height, especially not with the px unit

  • You've used a lot of absolute positioning, which is really not needed in this case. You can build simple, modern, and efficient layouts and position your elements properly using Flexbox or CSS grid

  Marked as helpful

  0

  ---

  

  VicDev ☪︎•330

  @ViicDevPosted almost 3 years ago

  @Remus432 I will try to modify the absolute positioning and dimensions, thanks for the comment bro 🙏

  0
• 

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi Victor,

  Good solution, nice work!

  A few minor bits of feedback for you:

  • it might be cool to add some border-radius to your design to match the challenge
  • you could add transition: ease .3s; to your buttons to make the hover affect smoother
  • it's best practice to avoid setting fixed heights and widths for responsive design, the content usually dictates this. i'd recommend looking into this further. this is a really good free course

  Keep up the hardwork!

  Marked as helpful

  0

  ---

  

  VicDev ☪︎•330

  @ViicDevPosted almost 3 years ago

  @darryncodes apart from the border radius I missed the capital letters in the initials of the buttons, thanks for the advice, I will modify it soon and I will place the transitions 🙏

  0