Design comparison
SolutionDesign
Solution retrospective
This is my First site with scss. I wait for your comments to become better.
Community feedback
- @denieldenPosted almost 2 years ago
Hello Pandelis, You have done a good work! 😁
Some little tips to improve your code:
- Tip of graphic design: with
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font. - add
main
tag and wrap the card for improve the Accessibility - remove descriptive text in the
alt
attribute of the icon images because only decorative - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful0 - Tip of graphic design: with
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord